Comfort is key for any workout, so choose what you feel most at ease exercising in. Leggings tend to be more figure-hugging and compressive, which some find supportive and motivating. Shorts are breezier and lighter, ideal if you overheat easily or prefer more range of movement. Think about the activity too - leggings may be better for yoga while shorts are great for high-intensity cardio.
